search

adobe / aio-cli-plugin-runtime

Adobe I/O Runtime plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
15 stars 31 forks source link

action:update should not overwrite params #275

Closed purplecabbage closed 7 months ago

purplecabbage commented 1 year ago

Is your feature request related to a problem? Please describe.

When setting a param via aio runtime action update my/action --param KEY VALUE all other params are deleted. I don't think this is expected.

Describe the solution you'd like Only the specified params should be updated, all others should be left as is

Describe alternatives you've considered I thought this was an error, so I tried the same thing in the wsk cli and it has the same behavior. At a minimum we should document that this happens, with a warning. We could also add a flag to specify the exact behavior we want. A --force flag might be a better way of indicating that we want to kill all unspecified params.

Additional context I think the use case to surgically update a single param without changing others is more valuable than the current implementation.

We also need to look at --env, --annotation

aiojbot commented 1 year ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2066

purplecabbage commented 7 months ago

docs updated, this is deep in ow api territory and there is no easy way around this, the client cannot pull the params because they are encrypted and once deployed only available to the running action.