adobe / aio-cli-plugin-runtime

Adobe I/O Runtime plugin for the Adobe I/O CLI
https://www.adobe.io
Apache License 2.0
15 stars 31 forks source link

feat: reverse api <-> route alias #284

Closed MichaelGoberling closed 1 year ago

MichaelGoberling commented 1 year ago

Make aio runtime api the main command for managing Openwhisk API routes so it shows up in the aio runtime / rt help text, just like the wsk cli.

Notes

Related Issue

Closes https://github.com/adobe/aio-cli-plugin-runtime/issues/281

How Has This Been Tested?

Locally linked plugin, npm run test

Screenshots (if appropriate):

Before

image

After

image

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #284 (91d3b9b) into master (0229029) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #284   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         1736      1736           
  Branches       367       367           
=========================================
  Hits          1736      1736           
Impacted Files Coverage Δ
src/commands/runtime/api/create.js 100.00% <100.00%> (ø)
src/commands/runtime/api/delete.js 100.00% <100.00%> (ø)
src/commands/runtime/api/get.js 100.00% <100.00%> (ø)
src/commands/runtime/api/index.js 100.00% <100.00%> (ø)
src/commands/runtime/api/list.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

MichaelGoberling commented 1 year ago

@purplecabbage

Good points all around. Thanks for the review :pray:

Classes have been renamed to Api and README has been reverted to master

purplecabbage commented 1 year ago

Noice!