adobe / aio-cli

Adobe I/O Extensible CLI
https://www.adobe.io
Apache License 2.0
76 stars 33 forks source link

error logs running `aio app deploy` when using a console.json without logging into the org #330

Open jdelbick opened 2 years ago

jdelbick commented 2 years ago

Expected Behaviour

After running aio app use <path-to-json>, deploy should work regardless of login status in the org in developer console. I have the correct information (runtime namespace and auth) in the .env file so that should be enough to successfully deploy.

$ aio app deploy
Using local project's @adobe/aio-cli-plugin-asset-compute version 2.0.1

✔ Built 1 action(s) for 'dx/asset-compute/worker/1'
ℹ no frontend or a build already exists, skipping frontend build for 'dx/asset-compute/worker/1'
✔ Deployed 2 action(s) for 'dx/asset-compute/worker/1'
no frontend, skipping frontend deploy 'dx/asset-compute/worker/1'
Your deployed actions:
web actions:
  -> https://<org-im-not-logged-into>.adobeioruntime.net/api/v1/web/dx-asset-compute-worker-1/worker-ocr 
non-web actions:
  -> dx-asset-compute-worker-1/__secured_worker-ocr 
New Extension Point(s) in Workspace 'Stage': 'dx/asset-compute/worker/1'
Successful deployment 🏄

Actual Behaviour

I hit a bug accessing the extension points. ~It is unclear if the action had been deployed properly.~ I confirmed the action does still get deployed regardless of the error message. However, this error message should be hidden or not shown. It should show "successful deployment" to the user.

$ aio app deploy
Using local project's @adobe/aio-cli-plugin-asset-compute version 2.0.1

✔ Built 1 action(s) for 'dx/asset-compute/worker/1'
ℹ no frontend or a build already exists, skipping frontend build for 'dx/asset-compute/worker/1'
✔ Deployed 2 action(s) for 'dx/asset-compute/worker/1'
no frontend, skipping frontend deploy 'dx/asset-compute/worker/1'
Your deployed actions:
web actions:
  -> https://704227-802ivoryhalibut-stage.adobeioruntime.net/api/v1/web/dx-asset-compute-worker-1/worker-ocr 
non-web actions:
  -> dx-asset-compute-worker-1/__secured_worker-ocr 
⠇ Getting Extension Points in Workspace=Stage... ›   Error: [CoreConsoleAPISDK:ERROR_GET_WORKSPACE_ENDPOINTS] 451 - Unknown ("Use POST /console/services/ims/organizations/:orgId/terms API to accept developer terms for 
 ›   your org first. You can use GET /console/services/ims/terms to retrieve the current developer terms.")

Reproduce Scenario (including but not limited to)

Steps to Reproduce

note: a and b are two different orgs

note: you are inside an app builder app

  1. run aio login or login to an org a in the developer console ui
  2. run aio app deploy (everything should work fine)
  3. run aio app use <path-to-json for a project in org b
  4. run aio app deploy You should see the action gets deployed but you get this error message in the console:
    ⠇ Getting Extension Points in Workspace=Stage... ›   Error: [CoreConsoleAPISDK:ERROR_GET_WORKSPACE_ENDPOINTS] 451 - Unknown ("Use POST /console/services/ims/organizations/:orgId/terms API to accept developer terms for 
    ›   your org first. You can use GET /console/services/ims/terms to retrieve the current developer terms.")

    I've also seen 401 errors pop up here.

Environment Info

  System:
    OS: macOS 11.5.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 455.66 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
  Virtualization:
    Docker: 20.10.8 - /usr/local/bin/docker
  npmGlobalPackages:
    @adobe/aio-cli: 8.2.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

aiojbot commented 1 year ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1850