adobe / aio-lib-console

Adobe I/O Javascript SDK wrapping Adobe Developer Console APIs
https://www.adobe.io
Apache License 2.0
1 stars 8 forks source link

feat: add get project install config endpoint #81

Closed MichaelGoberling closed 7 months ago

MichaelGoberling commented 7 months ago

Description

Add the new endpoint for fetching a project's install config

See Transporter API docs: https://developers.corp.adobe.com/adobeio/transporter/transporterSwagger.json#tag/Data/paths/~1console~1data~1projects~1{projectId}~1install-config/get

Related Issue

Motivation and Context

Allow template registry service to copy the install config for a given project

How Has This Been Tested?

Locally linked package, npm run test

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2794a50) to head (87a5b4e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 505 513 +8 Branches 15 15 ========================================= + Hits 505 513 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shazron commented 7 months ago

Was this just a drop-in from their OpenAPI spec file or you had to copy and paste this in?

MichaelGoberling commented 7 months ago

@shazron

This was a copy and paste, I originally did a full copy but there were a lot more changes than I expected, including some changes to existing paths (may have been breaking changes?). Should we create a follow-up task to sync with the latest?

shazron commented 7 months ago

@MichaelGoberling we've been doing patches for one-off additions: https://github.com/adobe/aio-lib-console/tree/master/spec/patch - this is so we can just drop-in any new Transporter specs. But now that you mentioned that there are other breaking changes, not sure

MichaelGoberling commented 7 months ago

@shazron

Ah, I see. I think the patch is needed for that one xr endpoint because it isn't in the Swagger definition. The endpoint I added as part of this PR is part of the Swagger, I just decided to forgo doing the full drop-in because it included more changes than I expected. Let me try to do the full drop-in and do some testing on this PR

Edit: Okay, just pushed a change doing the full drop-in. I updated any endpoints we currently support in index.js and left any new endpoints alone. The endpoints that had path changes were not in index.js, so I think we're good there