adobe / aio-lib-core-logging

Node.js Logger module for use by the Adobe I/O SDK

https://adobe.io

Apache License 2.0

2 stars 4 forks source link

add: string substitution support #25

Closed rajarju closed 4 years ago

rajarju commented 4 years ago

Description

Adding support for string substitutions in AioLogger Both debug and winston logger will support string substitution

Related Issue

Fix: #20

Motivation and Context

How Has This Been Tested?

With unit tests
local test implementations

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           89        90    +1     
  Branches        12        12           
=========================================
+ Hits            89        90    +1

Impacted Files	Coverage Δ
src/AioLogger.js	`100.00% <100.00%> (ø)`
src/DebugLogger.js	`100.00% <100.00%> (ø)`
src/WinstonLogger.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9610165...a2a7919. Read the comment docs.

rajarju commented 4 years ago

@moritzraho

thanks for doing this @rajarju got annoyed by this multiple times 😄 lgtm just maybe missing a last one here https://github.com/adobe/aio-lib-core-logging/blob/rajarju/string-interpolation/src/DebugLogger.js#L90?

I guess I did miss this, May be will add tests for other formats too

moritzraho commented 4 years ago

lgtm !