adobe / aio-lib-core-logging

Node.js Logger module for use by the Adobe I/O SDK
https://adobe.io
Apache License 2.0
2 stars 4 forks source link

fix: consistent variadic argument support in all loggers #36

Closed shazron closed 1 year ago

shazron commented 1 year ago

Closes #21 - however since it is using util.inspect, there is no indenting of json objects Closes #16

How Has This Been Tested?

npm test

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #36 (7d1852a) into master (5b48433) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          134       132    -2     
  Branches        22        24    +2     
=========================================
- Hits           134       132    -2     
Impacted Files Coverage Δ
src/AioLogger.js 100.00% <100.00%> (ø)
src/DebugLogger.js 100.00% <100.00%> (ø)
src/WinstonLogger.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shazron commented 1 year ago

LGTM!

d'oh! it was a nice exercise, but I just realized I was just re-implementing node:util.format 😱 Reworking this PR

shazron commented 1 year ago

Fixed 😅 (build failures because of eslint-plugin-import 2.27.0, which is pending a patch)