adobe / aio-lib-core-logging

Node.js Logger module for use by the Adobe I/O SDK
https://adobe.io
Apache License 2.0
2 stars 5 forks source link

Tests fail for winston >= 3.13 #58

Open moritzraho opened 4 days ago

moritzraho commented 4 days ago
TypeError: Cannot read properties of undefined (reading 'bind')

      41 |     switch (transports) {
      42 |       case 'console':
    > 43 |         wTransports.push(new winston.transports.Console())
         |                          ^
      44 |         break
      45 |       default:
      46 |         if (typeof (transports) === 'string' && transports.toString().indexOf('.') !== -1) {

      at new Console (node_modules/winston/lib/winston/transports/console.js:40:38)
      at WinstonLogger.getWinstonTransports (src/WinstonLogger.js:43:26)
      at new getWinstonTransports (src/WinstonLogger.js:28:24)
      at new AioLogger (src/AioLogger.js:49:19)
      at Object.<anonymous>.module.exports (src/AioLogger.js:143:10)
      at Object.AioLogger (test/AioLogger.test.js:147:23)

see https://github.com/adobe/aio-lib-core-logging/pull/57#issuecomment-2421126660

For now, as a workaround we must pin to 3.12

aiojbot commented 4 days ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-3251