adobe / aio-lib-core-logging

Node.js Logger module for use by the Adobe I/O SDK
https://adobe.io
Apache License 2.0
2 stars 4 forks source link

change the way providers are required #7

Closed moritzraho closed 4 years ago

moritzraho commented 4 years ago

Description

This is a breaking change.

Types of changes

Checklist:

codecov-io commented 4 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          71     73    +2     
  Branches        8     10    +2     
=====================================
+ Hits           71     73    +2
Impacted Files Coverage Δ
src/AioLogger.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 365c9c8...27c3b38. Read the comment docs.

Himavanth commented 4 years ago

LGTM. Though i would like to keep the dynamic loading for flexibility, we can solve that later.