Closed moritzraho closed 4 years ago
Merging #7 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 71 73 +2
Branches 8 10 +2
=====================================
+ Hits 71 73 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/AioLogger.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 365c9c8...27c3b38. Read the comment docs.
LGTM. Though i would like to keep the dynamic loading for flexibility, we can solve that later.
Description
This is a breaking change.
rename providers: from './WinstonLogger' to 'winston' and './DebugLogger' to 'debug' => don't expose file names to end user
remove the dynamic require
require(config.provider)
=> avoid security issues where the user injects code into the require statement => by explicitly requiring/WinstonLogger
and./DebugLogger
bundlers such as parcel or webpack can follow the needed dependencies. (Dynamic require is a blocker for deploying TVM actions that depend on logger.)Types of changes
Checklist: