search

adobe / aio-lib-files

An abstraction on top of cloud blob storage exposing a file system like API
https://www.adobe.io
Apache License 2.0
10 stars 14 forks source link

Support for custom CDN host option #55

Closed moritzraho closed 9 months ago

moritzraho commented 4 years ago

Actual behavior

The CDN domain is fixed (see https://github.com/adobe/aio-lib-files/blob/master/lib/impl/AzureBlobFiles.js#L29) and points to the Adobe I/O Firefly CDN, this is a problem if the user is bringing his own storage via Files.init({ azure: <storage creds> }) as URLs would be broken.

Expected behavior

~Support for a custom CDN host option on files init, e.g. Files.init({ host: 'mycdn.domain' })~ EDIT: Let the TVM return the hostname as part of the credentials, as the logic handling this is already added by #66

Why

moritzraho commented 4 years ago

relates to #52

aiojbot commented 4 years ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-898

moritzraho commented 3 years ago

Reopening because #66 did not solve the case of using non-prod TVMs, the TVM should return the CDN host name. Which would fix this transparently

moritzraho commented 9 months ago

Closing this stale issue as https://github.com/adobe/aio-lib-files/pull/90 brought support for our stage TVM.