sandeep-paliwal commented 3 years ago

Fixes https://github.com/adobe/aio-tvm/issues/46 Added check for presence of custom policies in case of BYO credentials. If custom policies are detected init will throw error reporting the same. Added policy prefix to easily detect policies created by aio-lib-files

TODO - add and fix existing unit tests

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

moritzraho commented 3 years ago

also missing unit tests

codecov[bot] commented 3 years ago

Codecov Report

Merging #97 (de20570) into master (d34c5a1) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head de20570 differs from pull request most recent head 9713186. Consider uploading reports for the commit 9713186 to get more accurate results

@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          546       557   +11     
  Branches        95        98    +3     
=========================================
+ Hits           546       557   +11

Impacted Files	Coverage Δ
lib/FilesError.js	`100.00% <100.00%> (ø)`
lib/impl/AzureBlobFiles.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d34c5a1...9713186. Read the comment docs.

adobe / aio-lib-files

Fix BYO custom access policy flow #97