Open moritzraho opened 4 years ago
The src/ims.js
already provides async getAccessToken (authCode, clientId, clientSecret, scopes) {
the idea is that the plugin would wrap this function to additionally provide context and caching mechanisms
@moritzraho @shazron : I started working on a separate plugin and have a working version running on my local machine. Can you guys let me know how to proceed in terms of logistics? Shall I raise a PR from my personal space?
Here's a PR for review: https://github.com/honstar/aio-lib-ims-s2s/pull/1. cc: @moritzraho @shazron @meryllblanchet
Hi @honstar, thanks, I will open a repository in git.corp and go through the open sourcing process to get it as part of the adobe org.
In the meantime we will look at your PR 🙂 , thank you so much !
Also, you can open a PR against this repository to integrate your plugin into: https://github.com/adobe/aio-lib-ims/blob/master/src/token-helper.js in the same way the jwt plugin is handled there. (we will publish the npm package later, but we will be able to test through local linking)
@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s
already and you start testing via local linking?
@moritzraho : I can do that, sure. Shall I use @adobe/aio-lib-ims-s2s already and you start testing via local linking?
Sure I think @adobe/aio-lib-ims-s2s is a good name maybe let's ask @meryllblanchet too for the naming?