Support PEM PKCS#8 private keys

[kwin]

This closes #11

Description

Provide helper methods to get a private key from a PEM encoded PKCS#8 string

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] I have signed the Adobe Open Source CLA.
• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[codecov[bot]]

Codecov Report

Merging #12 (44506a3) into main (1515519) will increase coverage by 0.21%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
+ Coverage     89.19%   89.41%   +0.21%     
- Complexity      160      166       +6     
============================================
  Files            13       14       +1     
  Lines           537      548      +11     
  Branches         47       47              
============================================
+ Hits            479      490      +11     
  Misses           41       41              
  Partials         17       17              

Flag	Coverage Δ	Complexity Δ
unittests	89.41% <100.00%> (+0.21%)	0.00 <6.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
.../io/adobe/cloudmanager/AdobeClientCredentials.java	100.00% <100.00%> (ø)	6.00 <6.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1515519...44506a3. Read the comment docs.

[bstopp]

Can you fix the merge conflict and add a test for this? Something that validates the String against the originally generated key pair.

[kwin]

If you are fine with the place of this static method I will add a test.

[bstopp]

Actually - now that I'm thinking about this i think there are more things to unpack:

• Yes I'm fine with the static method to generate the Key from a string.
• The Key property should be changed to PrivateKey to be accurately descriptive.
• This class (even though i already merged #13 ) should not implement Serializable.
  • Here's why: by making this class serializable it will lend itself to being abused in Jenkins and passed between steps, but these are secrets, and with Serializable and not using hudson.util.Secret - they will be passed around in clear text.
  • (Won't add Secret fields as that context is only one use of this library, albeit likely/eventually the most popular)

WDYT?

[kwin]

@bstopp I changed this PR as you suggested. Please have another look.