adobe / aio-lib-java-cloudmanager

Java wrapper to the Adobe Cloud Manager API.
https://opensource.adobe.com/aio-lib-java-cloudmanager/
Apache License 2.0
3 stars 9 forks source link

Change implementation to Feign to align with AIO Lilb #76

Closed bstopp closed 1 year ago

bstopp commented 1 year ago

Description

Removed the swagger API implementation and swapped it for Feign. This allows using the upstream API and creates consistency.

Also adding (some) missing APIs

Related Issue

39

Motivation and Context

See above.

How Has This Been Tested?

Re-implemented every previous existing test case. Added new tests for all new APIs.

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (e3149cf) into main (d242e6b) will decrease coverage by 0.39%. Report is 3 commits behind head on main. The diff coverage is 91.38%.

@@             Coverage Diff              @@
##               main      #76      +/-   ##
============================================
- Coverage     91.92%   91.53%   -0.39%     
- Complexity      212      426     +214     
============================================
  Files            22       52      +30     
  Lines           755     1110     +355     
  Branches         64       94      +30     
============================================
+ Hits            694     1016     +322     
- Misses           42       63      +21     
- Partials         19       31      +12     
Flag Coverage Δ
unittests 91.53% <91.38%> (-0.39%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...o/adobe/cloudmanager/CloudManagerApiException.java 100.00% <100.00%> (+8.49%) :arrow_up:
...c/main/java/io/adobe/cloudmanager/ContentFlow.java 100.00% <100.00%> (ø)
src/main/java/io/adobe/cloudmanager/Pipeline.java 100.00% <100.00%> (ø)
.../java/io/adobe/cloudmanager/PipelineExecution.java 100.00% <100.00%> (ø)
...adobe/cloudmanager/PipelineExecutionStepState.java 100.00% <100.00%> (ø)
...rc/main/java/io/adobe/cloudmanager/StepAction.java 100.00% <ø> (ø)
...udmanager/exception/DeleteInProgressException.java 100.00% <100.00%> (ø)
...oudmanager/exception/PipelineRunningException.java 100.00% <100.00%> (ø)
...ain/java/io/adobe/cloudmanager/impl/FeignUtil.java 100.00% <100.00%> (ø)
.../java/io/adobe/cloudmanager/impl/VariableImpl.java 100.00% <100.00%> (ø)
... and 42 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more