Description

Currently, retries are implicitly enabled from Feign, using the Default Retryer and with a maximal number of attempts of 5.

The code changes enable the use of resiliency4j retries:

retry RetryableException only
use an exponential backoff strategy, or the Retry-After header information when available, in which case use the maximum between the time given from the two.
disable internal retryer: https://github.com/resilience4j/resilience4j/issues/1858

Other approaches:

simply use the Default Retryer but configure a maximum number of retries of 3 (default is 5).
Extend the Retryer interface and implement our custom logic (parameters are a bit different + in case of a negative interval from the header the default retryer doesn't wait)

I think we might be good with just (1) if we do not need any other resiliency pattern, which involves only adding 1 line when creating the Feign builder:

       .retryer(new Default( ... , ... , 3)) // can configure startInterval and maxInterval, last is the number of attempts

Related Issue

150

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

adobe / aio-lib-java

feat: enhance Feign utility using resiliency4j retries #149