adobe / aio-lib-java

Adobe I/O - Java SDK
https://opensource.adobe.com/aio-lib-java/
Apache License 2.0
5 stars 18 forks source link

WIP OAuth2 Support #165

Closed bstopp closed 1 year ago

bstopp commented 1 year ago

Description

Update API to support OAuth Server-to-Server client credentials approach to Authentication.

Related Issue

155

Motivation and Context

Updates library to prepare for removal of deprecated JWT solution.

How Has This Been Tested?

Update existing unit tests, and added new ones.

Screenshots (if appropriate):

Types of changes

Checklist:

rperelma commented 1 year ago

Wow, thank you @bstopp !!! @francoisledroff is out this week, but will review when he is back.

bstopp commented 1 year ago

@francoisledroff - I don't know why the integration tests are failing. Its saying NPE, which indicates it can't find the fallback properties file. The actions should have all the necessary properties defined to successfully run these checks.

I don't have the information necessary to run the IT tests offline. I'm not sure if this is something you can do, to check the updates and make sure it wasn't something i introduced?

bstopp commented 1 year ago

I went ahead and updated all the plugins and dependencies to latest releases.

I'll be going back and adding more tests over the next couple of days while folks find time to review.

francoisledroff commented 1 year ago

@bstopp the IT tests are leveraging GH secrets only available on the main remote repo. If you push your change against a remote branch and update your PR accordingly, the IT test should run (using the deprecated JWT authentication)

bstopp commented 1 year ago

Closing this in favor of #166