search

adobe / aio-lib-java

Adobe I/O - Java SDK
https://opensource.adobe.com/aio-lib-java/
Apache License 2.0
6 stars 19 forks source link

`slf4j 2.0` (hence `aio-lib-java` `1.1.0`) is not supported by `sling`/`aem` #182

Closed francoisledroff closed 2 months ago

francoisledroff commented 1 year ago

If you are an AEM customer, please use a previous release.

see https://issues.apache.org/jira/browse/SLING-11906

rombert commented 1 year ago

From a Sling point of view it's a long way to SLF4j 2.0 compatibility because we have lots of consumers that are bound to slf4j 1.x because of their importing 'non-core' packages like org.slf4j.event or org.slf4j.helpers.

I am wondering whether this bundle really needs slf4j 2.0 or whether it works with both 1.x and 2.x and can relax its import constraints.

bstopp commented 1 year ago

Maybe leave the top-level slf4j dependency version to be 2.x, but the AEM sub-package parent pom overrides it downgraded to 1.x?

This way third party, non-aem uses can keep up-to-date, but the AEM bundles still deploy correctly to that context. Thoughts?

francoisledroff commented 2 months ago

closing this (should ahve done it a long time ago) as we downgraded sl4j to support aem see https://github.com/adobe/aio-lib-java/pull/185

I created a follow up issue : https://github.com/adobe/aio-lib-java/issues/225