adobe / aio-lib-java

Adobe I/O - Java SDK
https://opensource.adobe.com/aio-lib-java/
Apache License 2.0
6 stars 18 forks source link

Updates to Feign Header Processing #77

Closed bstopp closed 2 years ago

bstopp commented 2 years ago

Extract API Key header to separate AIO Request Interceptor.

So that can add the x-gw-ims-org-id header to requests .

francoisledroff commented 2 years ago

Thanks @bstopp could you shade some light on the motivation here ? x-gw-ims-org-id is added by the Adobe API gateway

bstopp commented 2 years ago

My understanding is that this header is required to make API calls:

It's not added by the gateway - it's required by the gateway.

francoisledroff commented 2 years ago

I see, thanks ! I'll review this further asap.

bstopp commented 2 years ago

Any update on this? I'm making updates to the aio-lib-java-cloudmanager library, which depends on this change.

francoisledroff commented 2 years ago

Looking good, I gave it a test and merged it