Feature/credential component

BaskarMitrah commented 12 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

deepessh commented 12 months ago

@BaskarMitrah found a few more bugs:

You should not be allowed to submit the form if the name is invalid. Steps to reproduce: a. Enter "test" in credential name b. Enter www.adobe.com in allowed domain c. Select download checkbox d. Select terms checkbox e. The create credential button gets enabled and the user is allowed to submit the form. Instead the create credential button should remain disabled because the credential name is not valid
Changing organization popup does not show the selected org (same as what @louisachu reported here) a. Click the change organization button b. From the popup select an org different than the one selected by default c. Click save d. Click the change organization button again e. Notice that the default organization is selected instead the current selected org should be selected by default
Noticed an error on the browser's console
Not sure why but the download API is getting called twice
There should be no return experience. Steps to reproduce: a. Submit the form to successfully create a credential b. Refresh the page or open a new window. The component stays on the card view c. Instead, the component should switch back to the form
The credential is always created in the same org. Steps to reproduce: a. Use the change organization link to change org to something other than default b. Fill the form and create the credential c. The credential gets created in the default org not the one selected by the user. Also, The card view shows the default org not the one selected by the user.
The Go to Developer Console link below the form should point to /console instead of https://developer.adobe.com/console/
I see an error boundary has not been setup for the component as well. If you would like, we can get on a call and discuss how to do that.
Zip download does not work. Steps to reproduce: a. I updated the download option in GetCredentialExternal.js to the following:
```
<GetCredential.Form.Download title="JavaScript" href="https://acrobatservices.adobe.com/dc-integration-creation-app-cdn/8bab684/files/samples_q3_2023/PROD/dc-pdf-services-sdk-java-samples.zip" />
```
Notice I have added a valid url. b. After submitting the form, I just get a zip file with name JavaScript.zip containing only credential.json. Instead, the zip file from the url should be downloaded with the credential.json injected.
The call to /console/api/organizations is being made every time the component renders.

BaskarMitrah commented 11 months ago

@BaskarMitrah found a few more bugs:
You should not be allowed to submit the form if the name is invalid. Steps to reproduce: a. Enter "test" in credential name b. Enter www.adobe.com in allowed domain c. Select download checkbox d. Select terms checkbox e. The create credential button gets enabled and the user is allowed to submit the form. Instead the create credential button should remain disabled because the credential name is not valid

Changing organization popup does not show the selected org (same as what @louisachu reported here) a. Click the change organization button b. From the popup select an org different than the one selected by default c. Click save d. Click the change organization button again e. Notice that the default organization is selected instead the current selected org should be selected by default

Noticed an error on the browser's console

Not sure why but the download API is getting called twice

There should be no return experience. Steps to reproduce: a. Submit the form to successfully create a credential b. Refresh the page or open a new window. The component stays on the card view c. Instead, the component should switch back to the form

The credential is always created in the same org. Steps to reproduce: a. Use the change organization link to change org to something other than default b. Fill the form and create the credential c. The credential gets created in the default org not the one selected by the user. Also, The card view shows the default org not the one selected by the user.

The Go to Developer Console link below the form should point to /console instead of https://developer.adobe.com/console/

I see an error boundary has not been setup for the component as well. If you would like, we can get on a call and discuss how to do that.
Zip download does not work. Steps to reproduce: a. I updated the download option in GetCredentialExternal.js to the following:
<GetCredential.Form.Download title="JavaScript" href="https://acrobatservices.adobe.com/dc-integration-creation-app-cdn/8bab684/files/samples_q3_2023/PROD/dc-pdf-services-sdk-java-samples.zip" />
Notice I have added a valid url. b. After submitting the form, I just get a zip file with name JavaScript.zip containing only credential.json. Instead, the zip file from the url should be downloaded with the credential.json injected.
The call to /console/api/organizations is being made every time the component renders.

1) Completed 2) Done 3) Not Showing now 4) Fixed 5) Fixed 6) Fixed 7) Fixed 8) Still Needs to be implemented 9) Fixed 10) Fixed

deepessh commented 11 months ago

@BaskarMitrah Thanks for fixing the bugs 🙌 . I just did another round of testing and looks like all the bugs are fixed except 7. It should be a quick fix though, I'll prepare a fix.

While switching orgs, I noticed a strange issue while switching to IO Team Org - Stage. I've shared a video with you on Slack.

I also see some css issue like on the side component:

Screenshot 2023-09-19 at 10 42 13 AM

BaskarMitrah commented 11 months ago

@BaskarMitrah Thanks for fixing the bugs 🙌 . I just did another round of testing and looks like all the bugs are fixed except 7. It should be a quick fix though, I'll prepare a fix.

While switching orgs, I noticed a strange issue while switching to IO Team Org - Stage. I've shared a video with you on Slack.

I also see some css issue like on the side component:

I've fixed the org changing issue

BaskarMitrah commented 11 months ago

Please fix all the links to be target to a blank tab instead of loading on the page.

Done

adobe / aio-theme