fix: maximize columns in discover block - Githubissues

adobe / aio-theme

The Adobe I/O theme for building markdown powered sites

Apache License 2.0

71 stars 45 forks source link

fix: maximize columns in discover block #1608

Closed melissag-ensemble closed 3 months ago

melissag-ensemble commented 3 months ago

Description

Issue: Even when there's room, Discover block limits itself two columns. For example

Screenshot 2024-07-30 at 7 30 19 PM

Root-cause: https://github.com/adobe/aio-theme/pull/1571

Related Issue

https://jira.corp.adobe.com/browse/DEVSITE-1154 https://jira.corp.adobe.com/browse/DEVSITE-1116

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

2-columns when page has side-nav:

3-columns when page has no side-nav:

Confirming no regressions on https://github.com/adobe/aio-theme/pull/1571 - i.e. hero is still aligned with overview + resources

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.