Fix for > 32 chars I/O Runtime namespaces and support < 64 chars - Githubissues

adobe / aio-tvm

Token Vending Machine, integrate external cloud services into I/O Runtime

https://www.adobe.io

Apache License 2.0

11 stars 13 forks source link

Fix for > 32 chars I/O Runtime namespaces and support < 64 chars #29

Closed moritzraho closed 4 years ago

moritzraho commented 4 years ago

Description

STS token generation fails for > 32 chars namespaces
evaluate if cosmos tvm needs some changes too
needs explicit doc and code for change to max = 63

needs an update to https://github.com/adobe/aio-lib-state#adobe-io-state-store-limitations-per-user and update to https://github.com/adobe/aio-tvm/blob/ed30c0009f8f9a624bbf74c53dd8e96d737c2045/lib/impl/AzureCosmosTvm.js#L34

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

moritzraho commented 4 years ago

ready to review, @sandeep-paliwal could you take a look?