adobe / aio-tvm

Token Vending Machine, integrate external cloud services into I/O Runtime

https://www.adobe.io

Apache License 2.0

11 stars 13 forks source link

Presign url support #30

Closed sandeep-paliwal closed 4 years ago

sandeep-paliwal commented 4 years ago

Added support to generate signature to access private storage files TVM will take following params to generate signature in a norma request 1) presignReq=true 2) blobName= 3) expiryInSeconds=

Description

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests and manual TVM deployment testing

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] I have signed the Adobe Open Source CLA.
[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
[x ] I have added tests to cover my changes.
[x ] All new and existing tests passed.

meryllblanchet commented 4 years ago

Adding @shazron as reviewer during @moritzraho 's time off.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@393ac6f). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             master       #30   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         9           
  Lines             ?       153           
  Branches          ?        10           
==========================================
  Hits              ?       153           
  Misses            ?         0           
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 393ac6f...1a35cf1. Read the comment docs.

sandeep-paliwal commented 4 years ago

@shazron I have updated the PR based on some changes I had discussed with @moritzraho changes you suggested will also get addressed with this.