adobe / alloy-samples

Apache License 2.0
8 stars 13 forks source link

Alloy personalization samples for AJO #10

Closed krishnanbalasubramanyam closed 1 year ago

krishnanbalasubramanyam commented 1 year ago

Adding alloy-samples for AJO alongside Target

Description

The PR contains alloy samples for AJO with different use cases similar to that of Target. The idea is to keep the AJO alloy-samples consistent with Target.

Motivation and Context

Alloy samples documented for AJO Code Based Experience Beta Release.

Checklist:

krishnanbalasubramanyam commented 1 year ago

Please update the scripts in the root package.json:

{
  "add-license": "node add-license.js",
  "format": "prettier --write \"{common,target,ajo}/**/*.{js,cjs,mjs,ts}\" \"**/*.md\""
}

and be sure to run both so that license headers exist for all files, and prettier formatting is applied.

Done!

krishnanbalasubramanyam commented 1 year ago

I noticed the target/personalization-hybrid-spa sample does not work, please take a look.

screenshot-2023-09-13 at 09 39 33@2x

made a few other comments as well.

I will take a look!

krishnanbalasubramanyam commented 1 year ago

I noticed the target/personalization-hybrid-spa sample does not work, please take a look. screenshot-2023-09-13 at 09 39 33@2x made a few other comments as well.

I will take a look!

This is fixed now. Could you check and let me know?

krishnanbalasubramanyam commented 1 year ago

Re-run checks!