Added docker hostonly isolation, moved remote proxy to run by default - Githubissues

adobe / aquarium-bait

Aquarium part to build stable and sturdy nested images

Other

3 stars 2 forks source link

Added docker hostonly isolation, moved remote proxy to run by default #38

Closed sparshev closed 1 year ago

sparshev commented 1 year ago

Changes:

Docker: Proper hostonly network isolation for docker images
CI: Added actual build / pack on linux host - very helpful with validation of the build scripts, proxies & isolation verification
AWS: Unified the post actions to report the image name just as the other providers
Proxy: rewrote remote proxy to properly handle http connections - before it failed trying to pass them
Updated README documentation

BREAKING:

Build: Removed not needed PROXY_REMOTE_LISTEN and used direct set of bait_proxy_url instead for simplicity
- Moved remote proxy to build_image.sh in order to allow to use it without ansible if needed (docker base images for example)
AWS: Moved to rolling images for linux to unify it for the cloud providers. You still can have solid state, but starting from your base images
Build: Improved packer spec alteration merger - now it's more flexible

Related Issue

fixes: #37 related: #31

Motivation and Context

Finally got struck on how to fix that issue

How Has This Been Tested?

Manually

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.