adobe / aquarium-fish

Your best secure distributed heterogeneous dynamic compute resource manager for CI

Other

7 stars 3 forks source link

Added golangci-lint and multiple fixes for all kind of checks #84

Closed sparshev closed 2 weeks ago

sparshev commented 3 weeks ago

The most important changes in this refactoring:

Added golangci to github workflow
Bumped version of go to 1.22 to fix for loops vars
Removed cluster logic since dead code and better one in #30
Fixed unauthorized access to application resource
Fixed not checked user struct type conversion in API
Multiple security and style fixes

Related Issue

82

Motivation and Context

When I saw how many issues is there - there no way around

How Has This Been Tested?

Manually

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.