adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

#117 - Fixed issue with property predicate breaking initial state due… #1118

Closed davidjgonzalez closed 6 months ago

davidjgonzalez commented 6 months ago

… cyclic dependency on group id generation

2024-04-24 at 11 01 AM

Description

Predicate Group ID creation called isReady() which called getItems() which ended up using the wrong groupID since that predicate's groupID hadnt been properly created it.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 27.79%. Comparing base (101d373) to head (66a0e4c). Report is 22 commits behind head on develop.

Files Patch % Lines
...ponents/predicates/impl/PropertyPredicateImpl.java 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1118 +/- ## ============================================= + Coverage 27.59% 27.79% +0.20% - Complexity 535 538 +3 ============================================= Files 179 180 +1 Lines 4657 4684 +27 Branches 658 662 +4 ============================================= + Hits 1285 1302 +17 - Misses 3189 3196 +7 - Partials 183 186 +3 ``` | [Flag](https://app.codecov.io/gh/adobe/asset-share-commons/pull/1118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/adobe/asset-share-commons/pull/1118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `27.79% <0.00%> (+0.20%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.