adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

Fixed issue with thumbnails not showing for assets missing dc:format #1159

Closed davidjgonzalez closed 4 months ago

davidjgonzalez commented 4 months ago

Fixed issue in AssetDelivery dispatcher where it would NPE if the dc:format property was not set on an asset (which appears to be the case for OFT files).

Also, added JS fallback support for imgs that dont load (to use the missing image, cliend-side).

2024-07-22 at 4 55 PM

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.19%. Comparing base (4a0ff9b) to head (64747ab). Report is 31 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1159 +/- ## ============================================= + Coverage 27.79% 28.19% +0.40% - Complexity 538 552 +14 ============================================= Files 180 182 +2 Lines 4684 4738 +54 Branches 662 673 +11 ============================================= + Hits 1302 1336 +34 - Misses 3196 3213 +17 - Partials 186 189 +3 ``` | [Flag](https://app.codecov.io/gh/adobe/asset-share-commons/pull/1159/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/adobe/asset-share-commons/pull/1159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `28.19% <100.00%> (+0.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.