adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

Update js.txt to import moment-with-locales.min.js #1176 #1177

Closed zhgeric closed 2 weeks ago

zhgeric commented 2 weeks ago

Update js.txt to import moment-with-locales.min.js

Description

I saw that moment-with-locales.min.js script was present but not used

Related Issue

https://github.com/adobe/asset-share-commons/issues/1176

Motivation and Context

Enable automatic translation for Metadata components when using datetime related metadata

How Has This Been Tested?

I changed this file on my locale environmment and it worked

Screenshots (if appropriate):

Before image After image

Types of changes

Checklist:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.19%. Comparing base (64747ab) to head (eeb07a7). Report is 23 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1177 +/- ## ========================================== Coverage 28.19% 28.19% Complexity 552 552 ========================================== Files 182 182 Lines 4738 4738 Branches 673 673 ========================================== Hits 1336 1336 Misses 3213 3213 Partials 189 189 ``` | [Flag](https://app.codecov.io/gh/adobe/asset-share-commons/pull/1177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/adobe/asset-share-commons/pull/1177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `28.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.