search

adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

PDF Viewer not loading on page refresh #1180

Closed RahulMohann closed 1 month ago

RahulMohann commented 2 months ago

Describe the bug We are using the PDF viewer component in our detail page to render pdf and other documents. We are observing the below behavior.

1) Login to the ASC and then open a pdf from the search page. It (detail page) loads for the first time and PDF is getting rendered in the pdf viewer component. 2) Refresh the same detail page once and the PDF viewer doesn't load. 3) Go back to search page and open another PDF, still the pdf viewer doesn't load. 4) Clear the browser cache and do refresh the detail page and the PDF viewer loads and render the document.

Any idea why this is happening and how to fix?

Environment

Thanks, Rahul

RahulMohann commented 2 months ago

Hi @davidjgonzalez , Could you please check?

davidjgonzalez commented 2 months ago

@RahulMohann im away until October.

Can you check to see if there are JS errors? Do you see the PDF download HTTP request taking place and completing in the Network panel?

I assume this is a problem with the PDF JS SDK since that is all clientside; all ASC does is popular the HTML/script tag w/ the configured values.

RahulMohann commented 1 month ago

Hi @davidjgonzalez, I see the document download request always happens successfully. But there is an iframe that doesn't get loaded when you refresh. Attached is the screenshot. If it's a client-side issue, how can we fix it?

Thanks, Rahul

RahulMohann commented 1 month ago
Iframe
davidjgonzalez commented 1 month ago

Hi @RahulMohann - Ah, i see it. Its a race condition -- the viewer.js has to be included before the event listener is registered. I'll cut a fix today.