search

adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

Change implementation of goToTop method #294

Closed fgrzelak closed 6 years ago

fgrzelak commented 6 years ago

Is your feature request related to a problem? Please describe. Current implementation changes window.location.hash which pushes state to browser's history. It prevents user of going back by browser's back button.

Describe the solution you'd like We'd like goToTop to do what it's meant to - scroll the page up. window.scrollTo(0, 0) would solve this.

fgrzelak commented 6 years ago

PR: https://github.com/Adobe-Marketing-Cloud/asset-share-commons/pull/295

davidjgonzalez commented 6 years ago

Thanks @fgrzelak - makes sense!