search

adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
89 stars 106 forks source link

Return Button only works the first time #447

Closed godanny86 closed 4 years ago

godanny86 commented 4 years ago

Describe the bug The "back" button the asset details page only works the first time.

Environment

To Reproduce Steps to reproduce the behavior:

  1. Perform a keyword search for "bike"
  2. Click into a result details page
  3. Hit the back button
  4. Search is maintained for the keyword "bike"
  5. Click into a second result details page
  6. Hit the back button
  7. Search result is not maintained.

Expected behavior The search result should be maintained until the user performs a new search.

Screenshots This looks to be an issue with the local storage of the returnUrl in that it gets reset the 2nd time:

image

Additional context Would need to revisit the javascript that populates the returnUrl in local storage: https://github.com/Adobe-Marketing-Cloud/asset-share-commons/blob/develop/ui.apps/src/main/content/jcr_root/apps/asset-share-commons/clientlibs/clientlib-site/js/navigation.js

schmidtkevina commented 4 years ago

I'll take this issue on and fix it.

schmidtkevina commented 4 years ago

This issue is now fixed.

godanny86 commented 4 years ago

Thanks @schmidtkevina !