search

adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

Scroll Buttons are not appearing for POP UP in asset share commons #568

Closed ashismit closed 3 years ago

ashismit commented 3 years ago

We have implemented asset share commons in the project. Issue is when a list of assets is added to a pop up the size of the pop up increases more then the screen and there is no scroll bar to see the whole POP UP.

Steps to reproduce.

  1. Go to the asset share commons serach page .
  2. Add 10 to 15 assets in the basket.
  3. Open the basket.
  4. You will notice the issue with the basket pop up.

Environment

Screenshot BasketScreen

davidjgonzalez commented 3 years ago

Does this have the same symptoms on a un-modified ASC installation? It looks like you've provided some custom CSS.

Also, what browser are you using?

ashismit commented 3 years ago

@davidjgonzalez the browser tested is firefox and mozilla.

ashismit commented 3 years ago

@davidjgonzalez also seeing the same on the un-modified ASC installation

Capture

davidjgonzalez commented 3 years ago

agh - yes, this was an issue with the height of the modal.

This is fixed in Asset Share Commons 2+ but if you want to drop your own CSS override put in something like this (which is the fix):

https://github.com/adobe/asset-share-commons/blob/develop/ui.apps/src/main/content/jcr_root/apps/asset-share-commons/clientlibs/clientlib-site/less/modals.less

davidjgonzalez commented 3 years ago

please re-open if the fix doesnt work for 1.x and/or if you cannot upgrade to 2.x (which is technicall a "breaking change" version - checkout: https://opensource.adobe.com/asset-share-commons/pages/getting-started/upgrade/ )