search

adobe / asset-share-commons

A modern, open-source asset share reference implementation built on Adobe Experience Manager (AEM)
https://opensource.adobe.com/asset-share-commons/
Apache License 2.0
88 stars 107 forks source link

asset type detection on pubishes #714

Closed baldeagle1947 closed 2 years ago

baldeagle1947 commented 2 years ago

Describe the bug On the publish, the assets are not detected precisely (PDF is marked PDF and not Documents). it impacts event wich detail page to display in a setup where you have custom behaviors by type (a Document reader in our cas for instance)

Environment

To Reproduce Steps to reproduce the behavior: Create a custom detail page for documents. on the publish just publish a document on asset share, and consult it (detail page)

Expected behavior The right page (details/document) should display.

Additional context the problem is that the logic that detects the type relies on this mapping /libs/dam/gui/content/assets/jcr:content/mimeTypeLookup for which everyone doesn't have access. I solved it by given access to everyone to this node only. but i think the best is to move this mapping in a more configurable place.

godanny86 commented 2 years ago

hey @baldeagle1947 that is interesting. I didn't think that was the case but can investigate. What version of 6.5 + SP?

baldeagle1947 commented 2 years ago

:) my tests were on the recent adobe AEM as A cloud SDK - exactly the aem-sdk-2021.10.5933.20211012T154732Z-210900 and some prior version - Equivalent i guess on these matters of ACL to the 6.5 + latest SP

godanny86 commented 2 years ago

Thanks @baldeagle1947 I can reproduce the issue.

This has caused confusion in the past and the logic of the Asset Type property isn't very clear. You also need a developer to view/extend the AssetType computed property to modify the behavior.

I'm thinking of introducing a configuration that would be set at the root of the Asset Share Commons Search page. Touch UI makes it a little ugly but hopefully straightforward:

image

WDYT?

apoorvvermarics commented 2 years ago

hi @godanny86 is there any ETA of what you are doing? When this can be available?

godanny86 commented 2 years ago

hi @apoorvvermarics I'd estimate mid May to have it be in a released version.

apoorvvermarics commented 2 years ago

Ok Thanks. But just to make sure if you understand the issue correctly. For us 2 separate users can see 2 different URL’s getting generated for 1 asset under search results in asset library page. Is this generation URL’s are based on permissions?

From: Daniel Gordon @.> Reply to: adobe/asset-share-commons @.> Date: Wednesday, 27 April 2022 at 1:32 AM To: adobe/asset-share-commons @.> Cc: Apoorv Verma @.>, Mention @.***> Subject: Re: [adobe/asset-share-commons] asset type detection on pubishes (Issue #714)

CAUTION: This email originated from outside of RICS. Do not click links or open attachments unless you recognise the sender and know the content is safe.

hi @apoorvvermaricshttps://protect-eu.mimecast.com/s/KtPSCjRY4SR3NZ2cRZBt3?domain=github.com I'd estimate mid May to have it be in a released version.

— Reply to this email directly, view it on GitHubhttps://protect-eu.mimecast.com/s/MBY_CgJp4SGmQ4ruNKKht?domain=github.com, or unsubscribehttps://protect-eu.mimecast.com/s/lpcxCkR24S5rGo7hQcQRo?domain=github.com. You are receiving this because you were mentioned.Message ID: @.***>

This message is intended only for the use of the individual or entity to which it is addressed and may contain information that is privileged, confidential and exempt from disclosure. It is strictly prohibited to disseminate, distribute or copy this communication if you are not the intended recipient, or an employee or agent responsible for delivering the message. If you have received this communication in error, please accept our apology and delete all copies. Please telephone the sender on the above number, +44 (0)247 686 8555, or email them by return. Royal Institution of Chartered Surveyors (RICS) Registered office: RICS, Parliament Square, London SW1P 3AD Registered Company no. 000487 VAT No. GB 584940013 This email message has been scanned for malware by Exchange Online Protection

godanny86 commented 2 years ago

The Asset Type of an Asset is dynamically generated by some logic that inspects the asset's extension and then uses a lookup of a node structure under /libs to determine whether the asset is of type Document, Image, Video, etc... The Asset Type drives the URL mapping to the corresponding asset details page. I suspect that is what is happening in your case as well (i.e if the user doesn't have permission to see the look up node structure, then the logic for determining the Asset Type is different).

FWIW you can view the logic here: https://github.com/adobe/asset-share-commons/blob/develop/core/src/main/java/com/adobe/aem/commons/assetshare/content/properties/impl/AssetTypeImpl.java#L80. Foolishly this was inspired by how the Assets UI on the authoring side determines the Asset type but of course Asset Share primarily runs on a Publish environment and thus has a different set of permissions for logged in via anonymous...

apoorvvermarics commented 2 years ago

Hi,

I have added the read permissions to path /libs/dam/gui/content/assets/jcr:content/mimeTypeLookup For our user or group but still URL generating is different.

From: Daniel Gordon @.> Reply to: adobe/asset-share-commons @.> Date: Wednesday, 27 April 2022 at 9:39 AM To: adobe/asset-share-commons @.> Cc: Apoorv Verma @.>, Mention @.***> Subject: Re: [adobe/asset-share-commons] asset type detection on pubishes (Issue #714)

CAUTION: This email originated from outside of RICS. Do not click links or open attachments unless you recognise the sender and know the content is safe.

The Asset Type of an Asset is dynamically generated by some logic that inspects the asset's extension and then uses a lookup of a node structure under /libs to determine whether the asset is of type Document, Image, Video, etc... The Asset Type drives the URL mapping to the corresponding asset details page. I suspect that is what is happening in your case as well (i.e if the user doesn't have permission to see the look up node structure, then the logic for determining the Asset Type is different).

— Reply to this email directly, view it on GitHubhttps://protect-eu.mimecast.com/s/ZMyRCgJp4SGmZrKSNvEar?domain=github.com, or unsubscribehttps://protect-eu.mimecast.com/s/4V5JCjRY4SR3Q2DhR8EO4?domain=github.com. You are receiving this because you were mentioned.Message ID: @.***>

This message is intended only for the use of the individual or entity to which it is addressed and may contain information that is privileged, confidential and exempt from disclosure. It is strictly prohibited to disseminate, distribute or copy this communication if you are not the intended recipient, or an employee or agent responsible for delivering the message. If you have received this communication in error, please accept our apology and delete all copies. Please telephone the sender on the above number, +44 (0)247 686 8555, or email them by return. Royal Institution of Chartered Surveyors (RICS) Registered office: RICS, Parliament Square, London SW1P 3AD Registered Company no. 000487 VAT No. GB 584940013 This email message has been scanned for malware by Exchange Online Protection

apoorvvermarics commented 2 years ago

@godanny86 additionally I searched our code and found that path used is /mnt/overlay/dam/gui/content/assets/jcr:content/mimeTypeLookup is this the correct path to provide permissions on? And I can not see this path in our CRX

apoorvvermarics commented 2 years ago

@godanny86 sorry i realised that I have not published the permissions hence not working. It works now. Thanks

davidjgonzalez commented 2 years ago

For others, here's a PR with the fix: https://github.com/adobe/asset-share-commons/pull/719

Still needs review (but its small) - and tbd if well merge based on danny's work (could be a good fallback tho)

davidjgonzalez commented 2 years ago

Fixed and release via #747 - Well try to get @godanny86 enhancement included in a minor version release.

baldeagle1947 commented 2 years ago

Sorry for my late reply (your email some how moved to spam), I think the solution you proposed is way easier and less magic under the hood, maybe it will be a good think to change the doc accordingly. Thanks a lot for your reactivity

Le mer. 6 avr. 2022 à 01:24, Daniel Gordon @.***> a écrit :

Thanks @baldeagle1947 https://github.com/baldeagle1947 I can reproduce the issue.

This has caused confusion in the past and the logic of the Asset Type property isn't very clear. You also need a developer to view/extend the AssetType computed property to modify the behavior.

I'm thinking of introducing a configuration that would be set at the root of the Asset Share Commons Search page. Touch UI makes it a little ugly but hopefully straightforward:

[image: image] https://user-images.githubusercontent.com/8974514/161866887-fb2d34f0-09c3-4fa6-b8fb-e21bd82d62b6.png

WDYT?

— Reply to this email directly, view it on GitHub https://github.com/adobe/asset-share-commons/issues/714#issuecomment-1089514298, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNFI4GJYWVWKO76MOAN6GTVDTDSJANCNFSM5RR3ZL4Q . You are receiving this because you were mentioned.Message ID: @.***>

-- Best regards

--- Benichou Jaouad --- Tél: 00 33 (0)7 61 59 03 23 --- Paris