search

adobe / brackets-edge-web-fonts

Edge Web Fonts extension for Brackets. Simply unzip and drop into your Brackets extension folder to browse and include Edge Web Fonts.
http://html.adobe.com/edge/webfonts/
MIT License
50 stars 20 forks source link

Script tag dialog is too wordy #114

Closed iwehrman closed 11 years ago

iwehrman commented 11 years ago

As discussed in #112 with @larz0 and @njx, the current script tag dialog is rather wordy:

3922

@larz0 suggested rewording thusly: 

 Add this JavaScript tag to the <head> of your website's HTML that
 reference this CSS file:

@iwehrman felt the need to add his own suggestion (which he now feels isn't quite right, but isn't yet ready to offer up something better): 

Edge Web Fonts are loaded with JavaScript. To use the fonts you've
chosen, paste the following script tag into HTML files that reference
this CSS file.

Perhaps PM @ryanstewart has some thoughts here.

ryanstewart commented 11 years ago

What about:

To ensure the fonts on your site load correctly add this script tag to the <head> of any HTML files that reference this CSS file.

:question:

Should there be a comma in there somewhere :question:

larz0 commented 11 years ago

Comma between "correctly" and "add"?

larz0 commented 11 years ago

BTW the close icon on the top right needs to center vertically in the modal header. Just realized it's been like that since the beginning.

ryanstewart commented 11 years ago

So this?

To ensure the fonts on your site load correctly, add this script tag to the <head> of any HTML files that reference this CSS file.

Does that work for people?

iwehrman commented 11 years ago

@larz0 I'll look into vertically aligning the close button. @ryanstewart That wording looks good to me.

iwehrman commented 11 years ago

@larz0 It looks like Brackets is still using the Bootstrap-default styling of <code> blocks with a light-orange background:

head

Think we should submit a Brackets pull to fix that? Otherwise I can just style it manually with a monospace font.

larz0 commented 11 years ago

@iwehrman I can't think of a reason why we would want to highlight an inline code snippet in Brackets right now because the font style is already the differentiator so let's submit a Brackets pull to remove the background color. (Hope I don't get busted this time lol).

iwehrman commented 11 years ago

OK, cool. Who wants it? Flip for it?

larz0 commented 11 years ago

(I already have too many pulls that won't make it into sprint.)

iwehrman commented 11 years ago

I'll lob another one over the fence.

iwehrman commented 11 years ago

Tracking https://github.com/adobe/brackets/pull/3949

couzteau commented 11 years ago

merged fix- closing