search

adobe / brackets-edge-web-fonts

Edge Web Fonts extension for Brackets. Simply unzip and drop into your Brackets extension folder to browse and include Edge Web Fonts.
http://html.adobe.com/edge/webfonts/
MIT License
50 stars 20 forks source link

Miscellaneous dialog fixes #139

Closed iwehrman closed 11 years ago

iwehrman commented 11 years ago

This fixes a handful of problems with the EWF dialogs that arose during the Brackets Sprint-26 jQuery/LESS/Bootstrap/modal-dialog upgrade. This patch fixes in particular:

  1. the vertical alignment of the modal header titles and close buttons;
  2. the font size and color of the code block in the insert dialog;
  3. an issue where the entire modal body of the picker dialog was scrollable inside the dialog;
  4. the alignment of the font tiles within the picker dialog;
  5. various dialog dismissal bugs, chief of which prevented close icon clicks from dismissing the dialog.
njx commented 11 years ago

The modal header padding was just tweaked globally in https://github.com/adobe/brackets/pull/4086, so that might obviate the need for the specific header fixes here.

iwehrman commented 11 years ago

Mmm, yeah. Reverting that part of that patch.