search

adobe / brackets-edge-web-fonts

Edge Web Fonts extension for Brackets. Simply unzip and drop into your Brackets extension folder to browse and include Edge Web Fonts.
http://html.adobe.com/edge/webfonts/
MIT License
50 stars 20 forks source link

[L10N][German]: Overlocalized Edge Web Fonts page and tooltip in German OS. #142

Closed julieyuan closed 11 years ago

julieyuan commented 11 years ago

Steps:

  1. Go to web page: creative.adobe.com
  2. Download Edge Code Preview 4 release build.
  3. Install Edge Code and launch it.
  4. Hover the mouse on the Edge Web Fonts icon on the top right of Edge Code, then click the icon to bring up Edge Web Fonts page

Results: The tooltip for the icon and the pop up page are overlocalized.

Expected: They should stay in English on non-French OSes.

ENV: German Mac 10.8 and Windows 7/8

Please refer to snapshots:

bildschirmfoto 2013-06-18 um 3 43 39 am bildschirmfoto 2013-06-18 um 3 45 36 am

iwehrman commented 11 years ago

Uh, do we actually want to turn off German localization here? I agree that it would be better if the whole product were localized, but might something be better than nothing? Any opinion, @pthiess @couzteau @ingorichter?

bchintx commented 11 years ago

submitted fix as Pull Request #146.

Removed German ("de") from master list of supported language translations (ie. nls/strings.js). Left the actual translated content in-place though for future use. When we want to re-enable the German translation (ie. when the rest of Edge Code supports German), then we can just re-add this one line.

couzteau commented 11 years ago

verified fix. Will go out with the next pre release drop

julieyuan commented 11 years ago

Fixed in Brackets master 0.28.0.8522 build. Not fixed in Edge Code 0.95.0-359081203 build yet. Will check it again in later Edge Code build. Here is the snapshot in master: bildschirmfoto 2013-07-24 um 10 16 03 pm

bchintx commented 11 years ago

Re-opening this issue. Per Julie's comment, please note that this fix won't be available until EWF is merged into EdgeCode via this pull request: https://git.corp.adobe.com/edge/edge-code/pull/190

bchintx commented 11 years ago

Pull Request 190 has been merged. Confirmed that this is now fixed in Edge Code master branch, and should be available to Julie in the next build.

@julieyuan please close this issue when you've confirmed the fix. Thanks!

julieyuan commented 11 years ago

Fixed in Edge Code build 0.95.0-359081293. Please refer to snapshot: bildschirmfoto 2013-07-25 um 7 12 20 pm