search

adobe / brackets-edge-web-fonts

Edge Web Fonts extension for Brackets. Simply unzip and drop into your Brackets extension folder to browse and include Edge Web Fonts.
http://html.adobe.com/edge/webfonts/
MIT License
50 stars 20 forks source link

Completion should be smarter if you type a font name with a space #22

Open njx opened 12 years ago

njx commented 12 years ago
  1. Bring up the EWF code hint menu
  2. Type "andale" and then hit space

Actual result: EWF assumes you're starting a new font name. Expected result: It would be nice if it were smart and assumed you were still typing the same font (since you haven't typed a comma), and add the quotes for you if you then accept a completion from the menu.

joelrbrandt commented 12 years ago

I agree. It's worth noting, however, that it does work properly if you start with a quote character. That is, if you've started with a quote, typing a space keeps you in the same token.

It also works right if you DON'T start with a quote, but then complete to a name with a space (before actually typing a space character). So, I think this is pretty low priority. Marking as such.

iwehrman commented 11 years ago

I'll look into this.

couzteau commented 11 years ago

PR was not sufficient covering all edge cases

couzteau commented 11 years ago

This should be closed. Fix has been merged

couzteau commented 11 years ago

Fix merged https://github.com/adobe/brackets-edge-web-fonts/pull/149