Hints don't appear automatically unless you code-complete 'font-family'

adobe / brackets-edge-web-fonts

Edge Web Fonts extension for Brackets. Simply unzip and drop into your Brackets extension folder to browse and include Edge Web Fonts.

http://html.adobe.com/edge/webfonts/

MIT License

50 stars 20 forks source link

Hints don't appear automatically unless you code-complete 'font-family' #69

Closed peterflynn closed 11 years ago

peterflynn commented 11 years ago

Open the latest EC preview 3 build
Open main.css in the Getting Started content
Make a new line inside the 'body' rule
Type font-family: (optional: and hit space)

Result: No EWF hints pop up

Expected: In preview 1 & 2, hints pop up at this point

Workaround:

Don't type 'font-family' yourself: type it partway, then hit Enter to accept the property name code hint. Then the EWF font hints will automatically appear (and they'll stick around if you hit space).
Type the first letter of any standard font name -- then the hints will appear (filtered to that letter). This only works with letters that have matches though (e.g. "x" will not cause hints to pop up).
Or explicitly hit Ctrl+Space -- that still shows the hints properly as well.

peterflynn commented 11 years ago

Updated title/description to clarify that this doesn't happen when using CSS code hints to "type" the property name.

redmunds commented 11 years ago

This was done intentionally to be more minimalistic as css code hints now are. As soon as you type a single letter, they pop up.

Note that if you choose font-family from the hints list, you will get the EWF dialog popped up at that point.

Do you think this is significantly different than CSS code hints, or were you just expecting it to behave the same as last time you used it?

peterflynn commented 11 years ago

Ok, good point -- I confirm it pops up as soon as you type a letter too. I'll add that to the workarounds & lower the priority. Doesn't seem like it should block EC.

I'll leave the bug open though since I think this is a case where we might want to consider popping up right away. After typing a “:” it seems pretty safe to pop up CSS value hints without being over-aggressive... unlike CSS property hints, there's not that much ambiguity here -- the user is basically guaranteed to either type a value, or a space and then a value... and that's about it).

peterflynn commented 11 years ago

One other note: these hints pop up less than the core Brackets CSS value hints. In core Brackets, if I type a property name and then colon [+ space], the hints popup that appeared while I was typing the property name remains open and now shows property values. With EWF this isn't true: the property name popup closes when I type colon.

iwehrman commented 11 years ago

I don't think this is a bug. The behavior of EWF in this context seems correct. The true bug, IMO, is that CSS value hints open as soon as you type the colon. That, I think, is far too aggressive.

iwehrman commented 11 years ago

In any case, I'll assign this to myself to either fix or take responsibility for closing after talking it over with the rest of the EC team.

iwehrman commented 11 years ago

Addressed by adobe/brackets#3848.

iwehrman commented 11 years ago

Fixed by adobe/brackets#3848. Closing.