Closed le717 closed 10 years ago
Oh, I forgot to say, I have tested this in Firefox, Opera, Chromium, and IE 11 and it all works.
I forgot to add 1. Some of the JavaScript came from the index (if you could not tell) and 2. I changed the order in which downloads are listed to WIN, OSX, LINUX32, LINUX64 rather than in reverse order (the way it was). The most traffic will be from Windows and Mac, so those should be listed first. It can be changed by reordering the platforms
object or by adding .reverse()
to the last $.each()
loop.
Reading through the code again, there are areas to improve (duplicate assignments, generating links even when hiding menu, more efficient code). Oh well. Plus, I did this as a small break from my ongoing projects. :)
@le717 Thank you. Let me have a look at your changes later today.
Don't think this is needed now that download.brackets.io points to brackets.io so I'll close this.
Thanks for trying to fix this @le717, we appreciate it!
@larz0 No problem. Like I said, I did this as a break from my personal projects. I did want to point out that there is some code in here that might still be of interest. The release number, for example, has to be hardcoded in the HTML every time a new release occurs. This gets the version number from updates.json (which is already being downloaded anyway) and uses it instead. So while the initial purpose of this PR is no more, you still may see something in here you could use.
I'll be quiet now. :P
@le717 No need to be quiet, all the help is appreciated and even if download.brackets.io is gone, maybe some things could be moved from here to brackets.io. We could probably use a popup to show the other downloads instead of sending you to github. But before doing anything for that, it might be better to discuss it a bit more with the team.
In light of adobe/brackets#7239 and various discussion I've seen about a new downloads page (which I presume to be this), I recreated the All Downloads menu from http://downloads.brackets.io, using a mix of existing and new code. I also performed some minor
"use strict";
and other fixes..json
file for dataIssues
window.version_url
is not ideal, IMO. I would think there is an easier way to make that a global variable..js
file for use on here and the index.