Closed marcelgerber closed 10 years ago
@jadbox Notice I changed Github
to GitHub
and Youtube
to YouTube
(case-only changes).
That's the way they pronounce themselves.
This is great. Once is merged I can make the spanish locale.
I have 2 requests:
@TomMalbran @pthiess Changes pushed.
OS X 10.9
, changed evolving.content
load.i18next.js
script
tags moved downjquery.min.js
neededDrive-by: We shouldn't translate the legal footer text, right?
Brackets was founded by Adobe as a community guided, open source project to push web development editors to the next level.
The project is released under an MIT License.
Well, I've got a bit of a problem right now. The requirements/installation buttons won't work. It's because of the Zepto update we needed. It works in IE9 where jQuery is used (but fails in IE8 because of some weird shit). Btw, notice that Foundation 5 won't work with Zepto (and maybe not even with jQuery 1.x, idk). http://zurb.com/article/1293/why-we-dropped-zepto
Notice the title isn't changed in IE8. IE9 works the way it should work.
@SAPlayer Great. I think that we can still clean up all the old js files into 2 specific file files. In the future we could combine all the js files.
I guess that we should just use jQuery, and since jQuery 1.11.x and 2.1.x have the same APIs any of those versions should probably work. Anyway, since we are dropping support for XP, it might make sense to also drop support for IE 6/7/8 and start using jQuery 2.x.
Sounds great, but I'd like to hear another ok for using just jQuery 2 (maybe @jadbox?). Well, I hope it's fine to have this many thirdparty libs/updates in this PR. Not much than Foundation 5 left :D Btw, I just noticed the site doesn't even work well in IE8, because there's no foreach method, but we use it to iterate through the blog posts. It'd be nice to have a little hint stating "Your browser is no longer supported. Please update."
@SAPlayer yep - @jadbox owns this page so I out a PM label on it and assigned it to him.
@SAPlayer Yep I'm good with using jQuery 2. Having a browser hint would be nice but not required for right now. How ready are you for this to be merged in?
@jadbox I won't have time until Thursday, but I can hopefully get everything done then.
Ready for another review. jQuery 2 is being used, README was added. (Works in IE9, but not in IE8 because of jQuery)
@jadbox
Will review it early this week for merging!
I'm currently reviewing the changes and had some merge conflicts because of my changes to brackets.io this morning. @SAPlayer would you mind updating the PR?
@SAPlayer I'm done with my review and have only a couple of minor nits. Great work! And I'm happy that you removed the obsolete libs that caused errors in the console.
@SAPlayer I forgot that ask one thing: the language will always be determined automatically. The only way to forcefully switch to a different language is to specify ?lang=locale
, correct?
Ready for another review.
Take a look at http://i18next.com/pages/doc_init.html.
?lang=locale
i18next
@SAPlayer Thanks for the update on the order to determine the locale.
@SAPlayer Thanks for the updates. Merged.
Thank you. That one looks and works great! (I may try working on Foundation 5, now that we use jQuery)
This is a follow-up of #39. See the page live (make sure you enable insecure content).
Changes made:
locales/de/translation.json
) @pthiess Could you please review the translation? @jadbox Could you please take a look at the structure of the translation object keys, the changes done to the.html
files and so on?Other changes:
jquery.reveal.js
- it wasn't needed and caused nothing but errors.