search

adobe / brackets.io

brackets.io website
111 stars 80 forks source link

Show spinner while loading version info. #71

Closed marcelgerber closed 10 years ago

marcelgerber commented 10 years ago

This is for adobe/brackets#7857.

TomMalbran commented 10 years ago

I think that it would be better to remove the initial features and just show the spinner instead of adding an opacity to the column as it is mentioned in adobe/brackets#7857.

marcelgerber commented 10 years ago

Hm, I vote for preserving them as there are several scenarios where loading takes long or won't even happen. Think of one with a mobile and slow network connection. Think of one with IE6, think of one with JS disabled (those two are basically the same :P). Think of one from a more poor country than the US or Germany, like India, where I guess the internet is slower.

TomMalbran commented 10 years ago

The issue is not a problem of not loading, but a problem of showing updates for an old Sprint that have nothing to do with the current Release. We don't really need to display these old updates. It might be a lot more useful to initially show a link to the release pages in GitHub and later replace that with the current notes. Same could be done with the Recent blog posts.

If you have JavaScript disabled you are stuck with the loading icon and an opacity over the old content, so I don't that is better than just showing the loading icon. If JavaScript disabled is an issue, which at this point it shouldn't, then the loading icon should be added with JavaScript.

njx commented 10 years ago

Agree with @TomMalbran.

marcelgerber commented 10 years ago

I agree, will change it tomorrow.

marcelgerber commented 10 years ago

@njx @TomMalbran Committed the change.

larz0 commented 10 years ago

@SAPlayer @TomMalbran this looks good. We should merge this once the conflict is fixed (my bad).

marcelgerber commented 10 years ago

@larz0 Fixed & squashed.

larz0 commented 10 years ago

Looks good, merging. Thanks @SAPlayer!