search

adobe / brackets.io

brackets.io website
111 stars 80 forks source link

Add info alert on WinXP #96

Closed marcelgerber closed 10 years ago

marcelgerber commented 10 years ago

Screens: English:

German:

@larz0 Are the colors ok?

peterflynn commented 10 years ago

@MarcelGerber Should we also do this for Mac OS X pre-10.6.8 and for Debian 7? We actually get confusion over Debian 7 far more often than we do with Win XP...

For Debian, we could have the info link point to: https://github.com/adobe/brackets/issues/4816

marcelgerber commented 10 years ago

@peterflynn That'd indeed be cool, but I guess we'd need two different alert texts, one specifically for XP (mentioning the blog post) and another for everything else (old OS X, Debian, Win 2000), probably linking to the Requirements page or to the requirements modal (which doesn't even mention Linux, btw). But I presumably won't get to that part until Monday.

larz0 commented 10 years ago

@MarcelGerber can we replace the button with that notification, make the background transparent and add a 1px solid white border?

peterflynn commented 10 years ago

@larz0 That seems nice -- as long as the "Other Downloads" link is still accessible, in case we mis-detect their OS.

@MarcelGerber Having a generic banner for the others seems fair. For Debian specifically though, it would be good to have a link to the bug I cited above -- since that seems to be the number one source of 'wrong OS' confusion for Brackets.

larz0 commented 10 years ago

@peterflynn yep we're not removing those links :+1:

marcelgerber commented 10 years ago

@larz0 I also thought about coloring the "Requirements" button sinde they don't fit. What about that?

larz0 commented 10 years ago

@MarcelGerber not sure what you meant, could you take a screenshot of "Requirements" not fitting? I'm assuming that we don't need to touch those three links below the download button.

marcelgerber commented 10 years ago

@larz0 Disregard that. It was a bad idea :D

marcelgerber commented 10 years ago

@larz0 Looks awesome :)

@peterflynn Detects some more now.

larz0 commented 10 years ago

@MarcelGerber thanks that looks great! @peterflynn can review the code. :+1:

marcelgerber commented 10 years ago

@ingorichter Could you take a look at this?

ingorichter commented 10 years ago

@MarcelGerber Sure, I'll do this after the meeting and the lunch break.

ingorichter commented 10 years ago

That was a long lunch break. I'm going to review this Friday morning.

ingorichter commented 10 years ago

Thank you.