adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

"Window" item in dropdown only translated into Japanese & French #10659

Open fmaida opened 9 years ago

fmaida commented 9 years ago

I'm actually testing Brackets 1.2 build 1.2.0.15689 on Mac OS X 10.10.2. When I change the language in brackets and I switch it to italian, I see that in the dropdown menu the item "Window" is not properly translated into "Finestra". Also, none of the sub-items inside the "Window" item are translated, and they appear in english.

I've also tried to switch to other languages such as French and German, and I noticed that the problem is still present: All the other menu items are properly translated with the exception of "Window".

This is a screenshot I've just taken:

window_e_menubar

Thank you for your time spent developing and debugging brackets

nethip commented 9 years ago

@rawat11 Can you check if these translations are missing in JP and Fr? And also please check these in both Brackets 1.1 and Brackets 1.2

fmaida commented 9 years ago

I can confirm that the translations are missing for both Japanese and French; I can also confirm that this issue seems to be present on the official release 1.1 as well.

Here's a screenshot from the japanese menu bar as it appears on my computer:

menubar_e_getting_started_ _brackets_e_download_e_brackets_release_1_1

nethip commented 9 years ago

@fmaida Thanks for trying out and confirming this!

@rawat11 Could you confirm if the Window menu is supposed to be translated or is the omission intentional?

peterflynn commented 9 years ago

@fmaida Those menus will always follow your OS language regardless of any language override you set via the Debug > Switch Language command. See https://github.com/adobe/brackets/issues/10114#issuecomment-66208410 and the code in PR adobe/brackets-shell#218.

So far we've been considering this not a bug, since the Debug menu item is unofficial (used only for testing), and thus normally all of Brackets follows the OS setting, keeping the menu translations consistent.

rawat11 commented 9 years ago

@fmaida Yes the menus will follow the OS language. If you do the same in Localized OS, the option would be localized in that particular language.

@nethip As of now its directly picking the OS language. But we can still get it confirmed if we need to provide its translation.

rawat11 commented 9 years ago

@peterflynn Do you think we need to provide its translation ?

peterflynn commented 9 years ago

@rawat11 It's already correctly translated to match the OS language, right? If so then I would think no additional translations are needed...

nethip commented 9 years ago

Closing this as changing the OS language is going to change the locale of the "Window" menu to that of the OS.

fmaida commented 9 years ago

@peterflynn The system language on my OS is currently set to Italian, and yet the name of that menu and the name of each item inside it are written in English instead.
If I have understand correctly, if that menu was meant to be translated in the same language as the OS language, then if I switch the language in brackets and I choose -for example- Japanese, even if the rest of the menu is written with japanese characters that menu item should always been translated "Finestra", but that's not my case... whatever language I choose for brackets, that menu item is always displayed as "Window". All the apps but Brackets use the word "Finestra" instead of "Window" and "Contrai" (or "Riduci a icona") instead of "Minimize".

peterflynn commented 9 years ago

@fmaida Ah, good point -- only the languages translated by Adobe have localizations for the native menus. Let's morph this into a bug about that issue...

peterflynn commented 9 years ago

The current translations are here: https://github.com/adobe/brackets-shell/tree/master/appshell/mac/French.lproj/MainMenu.xib https://github.com/adobe/brackets-shell/tree/master/appshell/mac/Japanese.lproj/MainMenu.xib

We'd need to get community translations matching the other locales that the JS side of Brackets supports.