adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.64k forks source link

Memory Leak after "search in files" #10838

Open lithiumbj opened 9 years ago

lithiumbj commented 9 years ago

it happened twice today, when i do a "search in files" on a middle size project (14400 Files and 245MiB Size) brackets passes from 220Mb to 580Mb (that is ok, it's a big quantity of files) but after the search finalize and you close the "search results" brackets is still using 500MiB~ of memory RAM, is not too much, but in my computer is 1/3 of all available RAM

Some extra data Brackets version + compilation: 1.2.0-15697 (Release 8f82e2a97) SO: xUbuntu 14.04 (latest kernel and updates) (32Bit SO) CPU: Intel Pentium D 2.8Ghz (Dual core), 1.5GB RAM

peterflynn commented 9 years ago

@lithiumbj This is expected -- Brackets caches all the files it's searched so your next search will be lightning-fast. Since you have 245 MB of files in your project, memory usage will increase by about the same amount after your first search.

Is this causing you any specific performance problems? Most other editors do something similar (e.g. Sublime or Webstorm).

You can reduce the number of files searched by setting an exclusion filter before you search.

marcelgerber commented 9 years ago

I'm a little confused by the fact that Brackets uses 220MB before. @lithiumbj, could you just start Brackets and see how much RAM it takes right after the start?

Sigmanor commented 8 years ago

Latest brackets release used 566 RAM on my win10. Other editors use less RAM.

evenstensberg commented 8 years ago

@Sigmanor Can I get your specs on your computer? Maybe it's due your graphics card or mainframe/ Processor

Sigmanor commented 8 years ago

@ev1stensberg Windows 10 x64 Motherboard Asus X550VC Intel Core i5-3230M 6gb RAM Nvidia GeForce GT 720m

abose commented 8 years ago

@Sigmanor brackets creates an in-memory index for search. If you want to disable this, open debug> open preferences file, and add "findInFiles.nodeSearch": false, to it. Note that this will disable instant search across files.

Can you paste you health report here? open help menu>health report