search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

Setting the code folding menu item-shortcuts fail (on Windows?) #11004

Open petetnt opened 9 years ago

petetnt commented 9 years ago

Windows 8.1., Brackets - Release 1.3 development build 1.3.0-0 (and the release itself) (no extensions)

  1. Open Brackets
  2. Check Developer Tools
  3. See two of these: Error setting menu item shortcut: 1

Threw a console.log before the line that throws the error and the key combinations that fail are ctrl+alt+[ and ctrl+alt+] which according to @redmunds display-brackets-shortcuts extension belong to codefolding.collapse and codefolding.expand.

redmunds commented 9 years ago

@petetnt Yes, I need to update my display-brackets-shortcuts extension to use another shortcut (https://github.com/redmunds/brackets-display-shortcuts/issues/44).

Does anything not work as expected? I have been seeing a similar error message on Brackets 1.2 (that I have not gotten around to reporting) with a shortcut override, but everything still works as expected.

petetnt commented 9 years ago

The menu items for Collapse Current and Expand Current do work, but their shortcuts don't, but I think that they the shortcuts themselves wouldn't work anyway as I am on a finnish keyboard layout and pressing CTRL+ALT+[ or ] is impossible (afaik?) as [ and ] are behind Alt Gr + 8 / 9

image (from http://frontype.com/keyboarding/540px-Computer-keyboard-Sweden.svg.png)

prafulVaishnav commented 9 years ago

Similar to #10970

mihawk90 commented 9 years ago

I am receiving the same error (Release 1.3 Build 1.3.0-16022).

I noticed that I didn't receive any errors on my Brackets installation on my Laptop (both my PC and my Laptop are Win8.1 64bit), so I went ahead and renamed my brackets folder in %appdata% to reset my settings, after that I didn't receive any errors.

I assume this is some older setting that is conflicting with something in the new code, as my Laptop's installation is completely new (1.3 is the first version ever installed on it), but the version on my PC has just been updated since 0.9 or something, I don't even remember.

Did any of you try the same, resetting your settings (temporarily) to see if it works? Also as mentioned in #10970 the binding is missing in the menu (with settings reset).

/edit As suspected, copying over the settings from my Laptop got rid of the error as well, so it isn't the installation, but rather a problem with the settings.

ficristo commented 8 years ago

Reloading without extensions now I see on the console three warning like this: Ctrl-Shift-`` (View -> Toggle Panels),Ctrl-Alt-[,Ctrl-Alt-]` They all seems impossible shortcut on Windows.