adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

Add padding/margin under Working Files header #11038

Open mfromin opened 9 years ago

mfromin commented 9 years ago

When there are no files open in the editor the "select a folder" section moves up near the top of the left panel and seems to obscure some of the buttons that would be on the working files panel.

From a look and feel perspective it would be nicer if the Working Files area never disappeared as it does at present. Perhaps some padding or margin beneath the "Working Files" title so that its never fully covered up?

Visible This looks good when I have at least one file opened... screen shot 2015-05-01 at 4 50 36 pm

Obscured Suddenly the whole Working Files "section" disappeared (mostly) screen shot 2015-05-01 at 4 50 53 pm

...note that a small sliver of the right-most button is still there. Just looks odd to me.

mfromin commented 9 years ago

From looking at Dev Tools it would appear that the DIV with id="working-set-list-container" gets set to display:none but a couple of buttons are outside of that DIV:

(see screenshot) so they can still be seen in some scenarios:

screen shot 2015-05-01 at 5 15 34 pm

Not losing the entire Working Files section would make for a more consistent user experience.

mfromin commented 9 years ago

This seems to override what Brackets is doing:

#working-set-list-container {
    min-height: 87px;   /* Based on the font I am choosing to use in Brackets */
}

.working-set-header, #working-set-list-container {
    display: block !important;
}
busykai commented 9 years ago

@mfromin, check if that repeats without any extensions (Debug -> Reload without extensions). it does look like you have a couple extensions installed which intervene the DOM directly. if it does not reproduce after you reload without extensions, then this is an extension issue, you should file it against the extension which causes it.

mfromin commented 9 years ago

It does still happen. From what I can tell Brackets changes the working-set-list-container visibility to display:none when there are no working files.

busykai commented 9 years ago

Working Set disappears when empty by design (unless you're in a split view). I thought the issue was that the split button was only partially visible (which is caused by the git extension rendering branch name there).

If I understand correctly, the issue seems to be the fact that Working Set disappears.

mfromin commented 9 years ago

If that is working by design then I guess my only comment would be I find that behavior odd in that a whole "section" of the UI disappears.