adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.64k forks source link

Code Hints Unreliable #11570

Open K-Thompson opened 9 years ago

K-Thompson commented 9 years ago

For me code hints are still unreliable after upgrading to v1.4 on two Windows 7 computers. In fact, today, it has not worked at all. I've tried to exclude files and folders, in the hope that reducing the number of files scan would solve the problem. I install v1.4 on one computer as a clean install. On the other computer, I installed over v1.3.

  1. I think on Windows 7, the file exclusion feature is not working (or I'm using it wrong). Notice the first two exclusion line with the '*' wildcard. Then look at the files added -- most from the folder being excluded.
{
    "jscodehints.detectedExclusions": [
        "C:/wwwroot/fin-calc/HC4/*",
        "C:/wwwroot/fin-calc/HC4/js/*",
        "C:/wwwroot/fin-calc/HC4/js/highcharts-3d.js",
        "C:/wwwroot/fin-calc/HC4/js/highcharts-3d.src.js",
        "C:/wwwroot/fin-calc/HC4/js/highcharts-more.js",
        "C:/wwwroot/fin-calc/HC4/exporting-server/phantomjs/heatmap.js",
        "C:/wwwroot/fin-calc/HC4/js/highcharts.js",
        "C:/wwwroot/fin-calc/HC4/exporting-server/java/highcharts-export/highcharts-export-web/target/highcharts-export-web/resources/js/runmode.js",
        "C:/wwwroot/fin-calc/HC4/js/highcharts.src.js",
        "C:/wwwroot/fin-calc/HC4/js/highcharts-more.src.js",
        "C:/wwwroot/fin-calc/HC4/js/themes/skies.js",
        "C:/wwwroot/fin-calc/HC4/exporting-server/phantomjs/highcharts-3d.js",
        "C:/wwwroot/fin-calc/HC4/js/themes/sand-signika.js",
        "C:/wwwroot/fin-calc/HC4/js/themes/grid.js",
        "C:/wwwroot/fin-calc/HC4/js/themes/grid-light.js"
    ]
}

My hunch is, the Inference Problem can be duplicated by adding the following open source libraries to your project folder.

jQuery DataTables Highcharts v4 fancyBox v2 Bootstrap

  1. Also, Brackets has Inference Problems and adds files to the json file throughout the working session. Can't the files for in a project folder be parsed up front, and they either fail or not?
  2. The entries in the json file use forward slashes in the path. I tried changing them to back slashes, as that is what Windows expects. But that resulted in an invalid json file. I'm wondering if the code does not handle the paths correctly on Windows?

I'm assuming that the Inference Problem is leading to code hinting failing.

Perhaps it would be useful for debugging if when code hinting is failing, that exceptions are raised?

Also, I know that code hinting can be enabled and disabled. I've tried the toggle, but I know of no indication anywhere that tells the user when code hinting is enabled or disabled. That might be useful too.

Hope the parsing can be resolved. The error and request for files has been in a lot of versions of Brackets.

marcelgerber commented 9 years ago

If we're lucky, #11569 helps fix this issue, too. I'd be happy to send you a binary so you can test yourself and report on your findings. Please let me know if you'd like to help test this upgrade.