adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.24k stars 7.63k forks source link

Remove custom fonts #13064

Open wolffe opened 7 years ago

wolffe commented 7 years ago

This is an OS-integration idea.

I think it would be better not to use Source Sans Pro for UI fonts, and only use OS-specific fonts, such as WordPress backend or GitHub:

font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

The font is better rendered and it integrates better with the various OS's out there.

petetnt commented 7 years ago

I like the idea in general, might be worth testing it out.

wolffe commented 7 years ago

I created my own theme, which replaces the vanilla fonts with the ones above. The theme is called The Greyhound and I have also released a plugin, called The Greyhound Companion, which changes more areas of the IDE, inaccessible to a regular theme.

swmitra commented 7 years ago

Good work @wolffe. Honestly I quite liked the idea of using a different font. But along with this we should try to resolve one more problem where in high dpi monitors rendering of file tree and status bar is quite useless. We need to use a user customizable font size for control panes as well. Could you think about some solution in that line?

wolffe commented 7 years ago

Maybe. I can only test it with 2 monitors, one 1440 and one 1920, but I'll have to check if I can add:

  1. Font size controls in the Theme panel.
  2. REM units for fonts, so they scale dynamically with the resolution.

I'm actively working on my theme and my plugin, as I'm coding on 3 different computers and I need them to look and behave the same.

swmitra commented 7 years ago

@wolffe I have seen this problem in my 4k 28inch monitor. Editor font size can be increased in Brackets but not the rest of the things. I am working on matching the code hint font size with that of code view, but the rest of the UI should also evolve.

wolffe commented 7 years ago

So, first of all, the change I am proposing is to change the current IDE font (Source Sans Pro) with the font stack in my original post.

Second, a bit offtopic, and this should have its own issue, the font size configuration. I agree with your points above. That's why I created a plugin to change the fonts that cannot be changed via a regular theme.

Please check The Greyhound theme and the The Greyhound Companion plugin.

ficristo commented 7 years ago

It seems there is also the system-ui font. But maybe we should update the fonts, see #12663