adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.64k forks source link

Title bar flashes when editing and onfocus/blur of the window #14437

Open SethClydesdale opened 6 years ago

SethClydesdale commented 6 years ago

Prerequisites

For more information on how to write a good bug report read here For more information on how to contribute read here

Description

Hello,

After updating to v1.13 I noticed that the title bar started flashing whenever I edit or focus/blur the editor; this did not occur prior. It almost appears like it's constantly losing/applying the window style.

Steps to Reproduce

  1. Open some files
  2. Edit the files and save/undo so the title is updated (displays/hides the "unsaved changes" icon) OR give focus to another window and then refocus the editor.
  3. Repeat step 2

Expected behavior: Modest UI that doesn't flash me.

Actual behavior: Shamelessly flashes me. Example: https://www.youtube.com/watch?v=CPk84XGO7Ek

Versions

Additionally, here's my potato's specs.

nethip commented 6 years ago

Thanks for reporting this @SethClydesdale. We will investigate this from our side.

@sobisht Is this anyway related to the fix that went this w.r.t window full resize on multi monitor? We could try reverting the fix and see if that reduces the window flashing.

nethip commented 6 years ago

@ayushrathi15 Could you check and recreate this from our side? More importantly please check if this is happening with 1.12.

nethip commented 6 years ago

@SethClydesdale Just for us to rule out if this is a regression in 1.13, can you tell us if this is happening only with 1.13 or was this happening with Brackets 1.12 as well?

SethClydesdale commented 6 years ago

@nethip It appears to be an issue with 1.13. I reverted back to 1.12 just to make sure and it's definitely more stable. There's no notable changes to the title bar when editing, focusing, or blurring.

The only thing I did notice was a small white line appearing under the menu bar (file, edit, find..) briefly when focusing/blurring the window; not when editing. It's not as noticeable as the title bar issue in 1.13, in fact I'd say it's quite minor, but I thought I'd mention it anyway just in case it's related.

sobisht commented 6 years ago

@SethClydesdale Thanks for your observations. We will work on the fix for the issue.

SethClydesdale commented 4 years ago

Hey, been awhile!

I decided to test the latest version (v1.14.2) and I can confirm that this issue is still persisting. I disabled all addons, defaults included, so they're definitely not the causes. I am wondering if perhaps this issue was caused by the border radius that was added to the title bar in v1.13? Because that's the only notable change I've noticed to it.

Though I've reverted back to v1.12, again, I'm curious to test this theory. Is there any way to modify/remove the border radius on the title bar?

griffi-gh commented 3 years ago

I have this issue too

SethClydesdale commented 3 years ago

Welcome to the club!! Don't think it'll ever get a fix, unfortunately. Only solution is probably a new PC, because I know mine is pretty outdated.