search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.64k forks source link

[I18N][JPN][Mac_only] Some CombinedChars are not supported so well that overlap issue happened. #2671

Open Chen-Dandan opened 11 years ago

Chen-Dandan commented 11 years ago
  1. Launch Brackets Sprint 19 5295.
  2. New a file by clicking File -> New File menu.
  3. Input the character " æ̀ (U+00 E6 03 00) ", " ə̀ (U+02 59 03 00) " or " ə́ (U+02 59 03 01) " in the Edit Field.
  4. Continue inputing any character in the cursor place.

Result: Overlap issue happened on the characters. See the screenshot below. Expected: All the characters display well.

Notes: Repro only on Mac.

Screenshot: Overlap_Uncode characters

njx commented 11 years ago

Reviewed. Marking low priority. Possibly another issue with composed characters. We should regress this in cmv3.

njx commented 11 years ago

Marking codemirror/tracking for now so we'll remember to see if we can close this.

njx commented 11 years ago

@Chen-Dandan, can you regress this in the sprint 20 build we're about to release? We want to see if this is fixed now that cmv3 is merged. Thanks.

Chen-Dandan commented 11 years ago

@njx, Hi, Jaramillo It still repro in the sprint 20 build 0.20.0-5678.

iwehrman commented 11 years ago

Still reproducible in Sprint 22 at a237877b3.

iwehrman commented 11 years ago

Note that this is not reproducible in the CodeMirror HTML or JavaScript demos that are currently included with Brackets. So unfortunately this is not likely to get magically fixed upstream. And yet it must to have something to do with CodeMirror...

dil77307 commented 11 years ago

It still repro in the sprint 23 build 0.23.0-6726 Overlapped problem

redmunds commented 10 years ago

This issue is unassigned, so marking "Needs Review".

Zhuyun commented 10 years ago

Just FYI, tried this issue with latest build 0.38.0.12173, it still reproduces on ENU Mac only. Also after input with Unicode Hex, cursor is missing in the edit field.

peterflynn commented 10 years ago

Reviewed - assigned @RaymondLim to investigate, low priority. We should try to repro in vanilla CM & file a bug on it if so.

RaymondLim commented 10 years ago

Can't repro in vanilla CM, but can repro in Brackets on both Windows and Mac. The issue is due to the Source Code Pro font that we used in Brackets. If I change the font to Times or Helvetica (default font used in Chrome), then I don't see the issue. Removing Mac Only label since we can see the issue on Windows as well. On Windows, the issue is not overlapping, but the accent character appears separately after the first unicode character. ie. instead of showing æ̀ , Brackets shows it as æ ̀. Sending it for review since we need to fix it in the font.

dangoor commented 10 years ago

Once the Themes work lands, people will have the ability to change the font which may be the more straightforward solution than trying to get Source Code Pro fixed.

dangoor commented 10 years ago

Removing the needs review label.