search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

Installer localization follows OS number/date formatting, not display language #2854

Open peterflynn opened 11 years ago

peterflynn commented 11 years ago

Sedat spotted this...

  1. Use an English OS (not sure if this is important: OS locale might not factor in)
  2. Leave "display language" set to English
  3. Set "locale" to French (basically just controls number & date formatting)
  4. Run Brackets installer

Result: Installer UI is in French. The UI of all other apps (including Brackets?) is in English.

Expected: Installer UI should follow display language, not formatting locale. (Or at least follow core OS locale -- but I think that concept went away in Windows 7).

peterflynn commented 11 years ago

Similar to #2668, this might be a fundamental limitation of multi-locale MSIs. I.e. the only way to fix might be to distribute separate installers for each language.

peterflynn commented 11 years ago

I'm also not sure how often people have these two settings disagree. Sedat thinks it may be fairly common in Europe to use English display language but e.g Turkish number/date formatting... But we haven't gotten any reports of this yet.

pthiess commented 11 years ago

Reviewed @jasonsanjose

pthiess commented 11 years ago

@jasonsanjose - I'm not sure if we have the bandwidth to change the MSI at this point but would ask you to verify what we could do. Thanks :)

peterflynn commented 11 years ago

Actually, this might be a dupe/superset of #1465... or at least similar...